Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add trial_columns argument in from_asc() #898

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

saeub
Copy link
Collaborator

@saeub saeub commented Nov 15, 2024

Description

Trial columns can be parsed from ASC files using custom patterns, but they cannot be easily set as trial columns. This PR adds trial_columns argument and passes it on to GazeDataFrame.__init__() (analogously to from_csv()).

Implemented changes

Insert a description of the changes implemented in the pull request.

  • Add trial_columns argument

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change is or requires a documentation update

How Has This Been Tested?

Let me know if I should write any tests for this change.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@github-actions github-actions bot added the enhancement New feature or request label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (870661a) to head (3447d2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #898   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           74        74           
  Lines         3419      3419           
  Branches       613       613           
=========================================
  Hits          3419      3419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saeub saeub marked this pull request as ready for review November 15, 2024 11:42
Copy link
Member

@SiQube SiQube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiQube SiQube force-pushed the from-asc-trial-columns branch from e81ffe0 to 3447d2f Compare November 27, 2024 09:07
@SiQube SiQube enabled auto-merge (squash) November 27, 2024 09:08
@SiQube SiQube merged commit 67a7bfa into aeye-lab:main Nov 27, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants